Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix borrow error when scheduling future inside an executor's callback #165

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

i509VCB
Copy link
Member

@i509VCB i509VCB commented Dec 21, 2023

No description provided.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6f6b88) 86.30% compared to head (ba35762) 86.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   86.30%   86.40%   +0.09%     
==========================================
  Files          16       16              
  Lines        2008     2008              
==========================================
+ Hits         1733     1735       +2     
+ Misses        275      273       -2     
Flag Coverage Δ
macos-latest 85.51% <100.00%> (+0.10%) ⬆️
ubuntu-latest 85.98% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the author of this code

@elinorbgr
Copy link
Member

Thanks!

@elinorbgr elinorbgr merged commit e4c8c5c into Smithay:master Dec 21, 2023
9 of 12 checks passed
@notgull notgull mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants